Re: [pbmserv-dev] Werewolf/Haggis code

[John Williams <williams@tni.com>]

On Wed, 21 Jul 2004, Geoff Hubbard wrote:
> Hi,
>
> I'm still spending my spare time on my cleanup of the Werewolf and the
> Common Game Perl files.  (Files at one stage were called:
> werewolf-refactor.pl and perlgame.pm)
>
> Most of my cleaning at the moment seems to be the removal of the global
> variables as globals REALLY annoy me. Unfortunately they have there
> talons in all over the place, but I'm getting there.

:)

That was a bit of laziness on my part.  I made some of the most commonly
used variables global, to save me a lot of search/replace time.

I'm glad you're doing it.

> As I go writing test cases for Werewolf with the hope that it may one
> day have a complete automated test script so that we can make changes to
> the codebase and know what we're breaking.

Hooray for automated testing!

I have some scripts I use for testing the C++ games I could send you.
They should work for werewolf as well.

> I don't currently have the Haggis code, and don't actually like haggis
> much so I probably won't be inspired to do the same for Haggis, but I'm
> happy to give advice to anyone who wants to do it.

Let me know when you are done, and I'll try to take on haggis.

> I hope no-one else is doing any changes to the codebase because merging
> will be horrible :)

I'm not doing anything currently.  I might program a few more haggis rules
to try to revive interest though.

> If anyone has any comments let me know.

Keep up the good work.

~ John Williams